-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky Wan Federation Failover Test #3032
Fix Flaky Wan Federation Failover Test #3032
Conversation
|
||
// Try again to rule out load-balancing. Errors can still happen so retry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~ I know this is status-quo so non-blocking: Do we know that LB would be round-robin in this scenario? Wondering whether multiple follow-up requests would be appropriate to prove we're not getting lucky. I did that in this test for similar reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, added something similar
Thank you for fixing this! |
ae0d043
to
3a44e5e
Compare
3a44e5e
to
ba8ff53
Compare
* fix check * add better check for load balancing
Changes proposed in this PR:
How I've tested this PR:
👀 / pipeline
How I expect reviewers to test this PR:
👀
Checklist: