Fix Flaky Wan Federation Failover Test #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
added
pr/no-changelog
zalimeni
approved these changes
Oct 3, 2023
|
|
||
| // Try again to rule out load-balancing. Errors can still happen so retry |
There was a problem hiding this comment.
~ I know this is status-quo so non-blocking: Do we know that LB would be round-robin in this scenario? Wondering whether multiple follow-up requests would be appropriate to prove we're not getting lucky. I did that in this test for similar reasons.
There was a problem hiding this comment.
good idea, added something similar
|
Thank you for fixing this! |
wilkermichael
force-pushed
the
mw/make-wan-fed-failover-more-reliable
branch
from
ae0d043
to
3a44e5e
Compare
wilkermichael
force-pushed
the
mw/make-wan-fed-failover-more-reliable
branch
from
3a44e5e
to
ba8ff53
Compare
wilkermichael
added a commit
that referenced
this pull request
Oct 4, 2023
* fix check * add better check for load balancing
2 tasks
wilkermichael
added a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
👀 / pipeline
How I expect reviewers to test this PR:
👀
Checklist: