Fix Gateway API CRDs #3065
Merged
Fix Gateway API CRDs #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
added
the
pr/no-changelog
david-yu
approved these changes
Oct 9, 2023
|
Thanks does this need to be backported? |
I was just looking at that. The regression did not get into 1.2.x so we are fine there. I don't see a release branch cut for 1.3.x yet so I don't think it needs backporting. |
t-eckert
added
the
pr/no-backport
|
@curtbushko FYI |
|
Lol, timing issue. I will do a manual backport. |
|
Oh, I guess I was looking for |
t-eckert
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Regenerate external Gateway CRDs * Remove errant .yml * Add external CRDs to copywrite ignore
|
Created #3066 |
t-eckert
pushed a commit
that referenced
this pull request
Oct 10, 2023
Fix Gateway API CRDs (#3065) * Regenerate external Gateway CRDs * Remove errant .yml * Add external CRDs to copywrite ignore
nathancoleman
added
backport/1.2.x
2 tasks
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
copywriteCLI deleted the Gateway CRDs we install. This would have broken us if it was released. I regenerated the external CRDs and added them to the Copywrite ignore given they are just pulled in from the Gateway SIG anyway and are not our IP.Changes proposed in this PR: