-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gateway API CRDs #3065
Fix Gateway API CRDs #3065
Conversation
Thanks does this need to be backported? |
I was just looking at that. The regression did not get into 1.2.x so we are fine there. I don't see a release branch cut for 1.3.x yet so I don't think it needs backporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you found this!
@curtbushko FYI |
Lol, timing issue. I will do a manual backport. |
Oh, I guess I was looking for |
* Regenerate external Gateway CRDs * Remove errant .yml * Add external CRDs to copywrite ignore
Created #3066 |
Fix Gateway API CRDs (#3065) * Regenerate external Gateway CRDs * Remove errant .yml * Add external CRDs to copywrite ignore
It looks like the
copywrite
CLI deleted the Gateway CRDs we install. This would have broken us if it was released. I regenerated the external CRDs and added them to the Copywrite ignore given they are just pulled in from the Gateway SIG anyway and are not our IP.Changes proposed in this PR: