Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL Updates for v2 ResourceAPI #3081

Merged
merged 1 commit into from
Oct 17, 2023
Merged

ACL Updates for v2 ResourceAPI #3081

merged 1 commit into from
Oct 17, 2023

Conversation

DanStough
Copy link
Contributor

@DanStough DanStough commented Oct 16, 2023 •
edited
Loading

Changes proposed in this PR:

  • Adds support for the new ACL Identity Permission. This includes using the new WorkloadIdentity Binding Rule so ACLs have the correct permissions to assume a WorkloadIdentity.

How I've tested this PR:

  • Unit Tests
  • V2 Acceptance Tests are passing in secure mode.

Checklist:

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Oct 16, 2023
@DanStough DanStough force-pushed the dans/NET-5319/v2-acls branch 3 times, most recently from a8613ae to 00b97e9 Compare October 16, 2023 20:04
@DanStough DanStough marked this pull request as ready for review October 16, 2023 20:04
ndhanushkodi
ndhanushkodi approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉 and thank you for the flakiness test fixes you made as a part of all this!

acceptance/tests/mesh_v2/mesh_inject_test.go Outdated Show resolved Hide resolved
@DanStough DanStough merged commit 2b0ef6a into main Oct 17, 2023
46 of 48 checks passed
@DanStough DanStough deleted the dans/NET-5319/v2-acls branch October 17, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@zalimeni zalimeni Awaiting requested review from zalimeni

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanStough @ndhanushkodi