Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare main for 1.4 dev #3092

Merged
merged 7 commits into from
Oct 19, 2023
Merged

prepare main for 1.4 dev #3092

merged 7 commits into from
Oct 19, 2023

Conversation

wilkermichael
Copy link
Contributor

Changes proposed in this PR:

  • There will probably be some issues until dataplane version of this is merged, so I'll re-run CI once those are in

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Oct 17, 2023
@wilkermichael
Copy link
Contributor Author

@curtbushko this look okay for the cloud tests?

@curtbushko
Copy link
Contributor

@wilkermichael Yes, that looks right.

I guess we will have to wait until main on every other project is updated with the correct versions too.

@DanStough
Copy link
Contributor

I made some changes to the PR to be consistent with having the minor version of the tag. I also remove the last usages of ::set-output::. Bullet successfully dodged.

@DanStough
Copy link
Contributor

I will also cherry-pick the docker changes to other branches.

Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As long as versions have -dev, I think we are good.

@wilkermichael wilkermichael merged commit d09fc3d into main Oct 19, 2023
28 of 48 checks passed
@wilkermichael wilkermichael deleted the mw/prepare-1-4-dev branch October 19, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants