Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dev tag #3094

Merged
merged 1 commit into from
Oct 19, 2023
Merged

remove dev tag #3094

merged 1 commit into from
Oct 19, 2023

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Oct 17, 2023

Changes proposed in this PR:

  • Remove dev tag so that we don't race against 1.3.x preview image

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

@wilkermichael wilkermichael changed the base branch from main to release/1.3.0 October 17, 2023 18:42
@wilkermichael wilkermichael added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Oct 17, 2023
@DanStough
Copy link
Contributor

I need to cut the branches in Consul before we merge this.

@DanStough
Copy link
Contributor

Waiting for tag changes to merge before this is fixed: hashicorp/consul#19278

@DanStough
Copy link
Contributor

FYI @david-yu @NicoletaPopoviciu . This PR was part of staging the .0 branch to ensure we are testing the code-freeze images. I'll merge once the tests go green.

@david-yu david-yu self-requested a review October 19, 2023 15:42
@wilkermichael wilkermichael merged commit 7a126e4 into release/1.3.0 Oct 19, 2023
43 of 48 checks passed
@wilkermichael wilkermichael deleted the mw/remove-dev-tag branch October 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants