Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6664 Specify cluster scope for MeshGateway CRD #3236

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Nov 21, 2023

Changes proposed in this PR:

  • Change the scope of the MeshGateway CRD to Cluster due to the fact that the resource is partition-scoped in Consul and thus should not have a namespace

How I've tested this PR:
Using this setup

$ helm upgrade --install consul <path_to_local_main_checkout>/charts/consul --values ./values.yaml
$ kubectl apply -f gateway.yaml

Instead of the namespace declaration error previously caused by the Namespaced scope, you'll see an error in the controller logs indicating that the create/update function is not yet implemented, which is expected.

ERROR    Reconciler error    {"controller": "meshgateway", "controllerGroup": "mesh.consul.hashicorp.com", "controllerKind": "MeshGateway", "MeshGateway": {"name":"mesh-gateway"},  │
│ "namespace": "", "name": "mesh-gateway", "reconcileID": "c3917aab-878d-48c5-adbc-d701bab04c1b", "error": "onCreateUpdate not implemented"}

How I expect reviewers to test this PR:
See above

Checklist:

@nathancoleman nathancoleman added theme/mesh-gw pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Nov 21, 2023
@nathancoleman nathancoleman requested a review from a team November 21, 2023 16:56
@nathancoleman nathancoleman changed the title Specify cluster scope for MeshGateway CRD NET-6664 Specify cluster scope for MeshGateway CRD Nov 21, 2023
@nathancoleman nathancoleman merged commit 6446f42 into main Nov 21, 2023
58 checks passed
@nathancoleman nathancoleman deleted the cluster-scoped-mesh-gateway branch November 21, 2023 18:57
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
Specify cluster scope for MeshGateway CRD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry theme/mesh-gw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants