NET-6664 Specify cluster scope for MeshGateway CRD #3236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
MeshGateway
CRD toCluster
due to the fact that the resource is partition-scoped in Consul and thus should not have a namespaceHow I've tested this PR:
Using this setup
Instead of the namespace declaration error previously caused by the
Namespaced
scope, you'll see an error in the controller logs indicating that the create/update function is not yet implemented, which is expected.How I expect reviewers to test this PR:
See above
Checklist: