-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Duplicate UBI Tags #3265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
emilymianeil
added
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
labels
Nov 27, 2023
jeanneryan
approved these changes
Nov 27, 2023
curtbushko
added
the
pr/no-changelog
PR does not need a corresponding .changelog entry
label
Nov 27, 2023
curtbushko
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Emily! This looks correct to me.
jm96441n
pushed a commit
that referenced
this pull request
Nov 29, 2023
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
kisunji
added
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
and removed
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
labels
Apr 3, 2024
This was referenced Apr 3, 2024
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
Remove Duplicate UBI Tags (#3265) - Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123 Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com>
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Prerelease 1.3.4 * [prerelease-1.3.4] Disable CE test (#3827) * [1.3.4] Disable all CE tests (#3835) Disable CE tests on all workflows * Backport of [NET-8601] Upgrade `vault/api` and `docker/docker` to resolve open CVEs into release/1.3.4 (#3843) * backport of commit 1711f31 * backport of commit 9049c0d * backport of commit cacd09b * [1.3.4] Remove Duplicate UBI Tags (#3265) (#3860) --------- Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Prerelease 1.2.7 * [prerelease-1.2.7] Disable CE test (#3826) * [1.2.7] Disable all CE tests (#3834) Disable CE tests on all workflows * Backport of [NET-8601] Upgrade `vault/api` and `docker/docker` to resolve open CVEs into release/1.2.7 (#3844) * backport of commit 1711f31 * backport of commit 9049c0d * backport of commit cacd09b * [1.2.7] Remove Duplicate UBI Tags (#3265) (#3859) Remove Duplicate UBI Tags (#3265) - Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123 Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com> * Re-add get-go-version (#3863) --------- Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com> Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com>
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
pr/no-changelog
PR does not need a corresponding .changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to avoid a production incident where there are duplicate tags (auto-assigned) to UBI images. The entire issue is described here, and can be avoided by building
UBI
s (intended for bothDockerhub
andRedhat
) in one step.PR Checklist