Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -enable-webhooks flag #336

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Add -enable-webhooks flag #336

merged 1 commit into from
Sep 25, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Sep 25, 2020

  • defaults to true
  • replaces ENABLE_WEBHOOKS environment variable

@lkysow
Add -enable-webhooks flag
608c17a 
- defaults to true
- replaces ENABLE_WEBHOOKS environment variable
@lkysow lkysow requested review from thisisnotashwin, a team and kschoche and removed request for a team September 25, 2020 15:26
kschoche
kschoche approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@lkysow lkysow merged commit c77a9f5 into crd-controller-base Sep 25, 2020
@lkysow lkysow deleted the enable-webhooks-flag branch September 25, 2020 15:44
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
@tehmoon
Use namespace environment variable instead of helm (hashicorp#336)
429899d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@kschoche kschoche kschoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkysow @kschoche @thisisnotashwin