Add acceptance test cleanup #3375
Conversation
curtbushko
force-pushed
the
curtbushko/delete-all-resources
branch
2 times, most recently
from
4ff0b61
to
fa98d44
Compare
curtbushko
added
pr/no-changelog
|
Just a heads up that we're entering a code-freeze today at some point (for the backports) so maybe hold off on merging until you check with @t-eckert |
| @@ -222,6 +223,66 @@ func (h *HelmCluster) Destroy(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Delete any deployments that have h.releaseName in their name. | |||
| deployments, err := h.kubernetesClient.AppsV1().Deployments(h.helmOptions.KubectlOptions.Namespace).List(context.Background(), metav1.ListOptions{LabelSelector: "release=" + h.releaseName}) | |||
There was a problem hiding this comment.
suggestion: Just a thought but might be worth having a function or something that we call that just generates "release="+h.releaseName since it's used everywhere. Less chance of accidentally mispelling/creating wrong string in the future.
| @@ -286,6 +347,51 @@ func (h *HelmCluster) Destroy(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Verify that all deployments have been deleted. | |||
| deployments, err = h.kubernetesClient.AppsV1().Deployments(h.helmOptions.KubectlOptions.Namespace).List(context.Background(), metav1.ListOptions{LabelSelector: "release=" + h.releaseName}) | |||
There was a problem hiding this comment.
are there any steps we can take if these resources still exist?
| require.NoError(r, err) | ||
| for _, deployment := range deployments.Items { | ||
| if strings.Contains(deployment.Name, h.releaseName) { | ||
| r.Errorf("Found deployment which should have been deleted: %s", deployment.Name) |
There was a problem hiding this comment.
Good idea to verify resource deletion... this will hopefully help us diagnose which resource is causing things not to be deleted properly in the future.
|
I will wait until after code freeze to merge this just so that we do not cause any problems. |
Ack. |
Add acceptance test cleanup
curtbushko
force-pushed
the
curtbushko/delete-all-resources
branch
from
fa98d44
to
a34177a
Compare
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
👀
Checklist