Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reflect.DeepEqual with gocmp.Equal #340

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Replace reflect.DeepEqual with gocmp.Equal #340

merged 7 commits into from
Sep 29, 2020

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Sep 29, 2020 •
edited
Loading

  • go-cmp has a more robust library for compares as it allows ignoring
    unexported fields.
  • Refactored the MatchesConsul tests for serviceDefaults to resemble other MatchesConsul tests

How I've tested this PR:

  • existing tests for MatchesConsul continue to pass.

How I expect reviewers to test this PR:

  • this is a refactor so existing tests passing should imply it was successful.

@lkysow lkysow mentioned this pull request Sep 29, 2020
Merged
Base automatically changed from crd-service-splitter to crd-controller-base September 29, 2020 20:39
lkysow
lkysow approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after rebase

api/v1alpha1/proxydefaults_types_test.go Outdated Show resolved Hide resolved
Restructure MatchesConsul test to test against mismatched type
63b035c 
- This ensures we dont have to necessarily write failing tests every
  time we add a field
ishustava
ishustava reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left one question, but otherwise, this looks good to me.

api/v1alpha1/proxydefaults_types.go Outdated Show resolved Hide resolved
ishustava
ishustava approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thisisnotashwin thisisnotashwin merged commit 3a97323 into crd-controller-base Sep 29, 2020
@thisisnotashwin thisisnotashwin deleted the go-cmp-equals branch September 29, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@lkysow lkysow lkysow approved these changes

Assignees
No one assigned
Labels
theme/crds type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisnotashwin @lkysow @ishustava