Refactor ent controller tests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This ensures we dont have to necessarily write failing tests every time we add a field
thisisnotashwin
force-pushed
the
refactor-ent-controller-tests
branch
4 times, most recently
from
b90cf28 to
bf0c6c8
Compare
thisisnotashwin
requested review from
lkysow,
a team and
kschoche
and removed request for
a team
lkysow
approved these changes
Sep 30, 2020
Comment on lines
29
to
32
| // NOTE: We're not testing each controller type here because that's done in | ||
| // the OSS tests and it would result in too many permutations. Instead | ||
| // we're only testing with the ServiceDefaults controller which will exercise | ||
| // all the namespaces code. |
There was a problem hiding this comment.
Need to update this comment a bit
kschoche
approved these changes
Sep 30, 2020
thisisnotashwin
force-pushed
the
refactor-ent-controller-tests
branch
from
bf0c6c8 to
a0c74d7
Compare
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Fixed template newline issue in connect-inject deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
controllerspackage tocontrollerValidatorstoWebhooksHow I've tested this PR:
How I expect reviewers to test this PR: