Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable TestConnectInject_LocalRateLimiting for cloud provider tests #3439

Merged
merged 1 commit into from
Jan 5, 2024
Merged

disable TestConnectInject_LocalRateLimiting for cloud provider tests #3439

merged 1 commit into from
Jan 5, 2024

Conversation

wilkermichael
Copy link
Contributor

Changes proposed in this PR

  • This PR disables the local rate limiting tests for cloud providers. This test is time sensitive and was consistently flaking on cloud. This doesn't test any features specific to cloud, so I think it is safe to disable this in our nightlies.

How I've tested this PR

How I expect reviewers to test this PR

Checklist

@wilkermichael wilkermichael added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 5, 2024
zalimeni
zalimeni approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wilkermichael wilkermichael merged commit 642a1ea into main Jan 5, 2024
32 of 55 checks passed
@wilkermichael wilkermichael deleted the mw/disable-rate-limiting-cloud-nightly branch January 5, 2024 18:38
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jan 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@kisunji kisunji kisunji approved these changes

Assignees
No one assigned
Labels
backport/1.3.x pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilkermichael @zalimeni @kisunji