Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ctrl-manifests to clean dirty state of main #3466

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

nathancoleman
Copy link
Member

Changes proposed in this PR

Running make ctrl-manifests on main cleans the dirty state that is leaking into unrelated work every time someone needs to run this command.

How I've tested this PR

Run command on this branch, verify clean.

How I expect reviewers to test this PR

See above

Checklist

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jan 11, 2024
@nathancoleman nathancoleman requested review from a team, NiniOak and t-eckert and removed request for a team January 11, 2024 16:01
@nathancoleman nathancoleman merged commit 4f5a5d3 into main Jan 11, 2024
44 of 55 checks passed
@nathancoleman nathancoleman deleted the ctrl-manifests-dirty branch January 11, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants