Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Gateway Deployment Configuration #3477

Merged
merged 16 commits into from
Jan 18, 2024
Merged

Mesh Gateway Deployment Configuration #3477

merged 16 commits into from
Jan 18, 2024

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Jan 16, 2024 •
edited
Loading

This PR largely wraps a bow on the configuration of deployment resources for Mesh Gateways.

It completes:

Changes proposed in this PR

  • Add BATs for Gateway Log Level Configuration
  • Pass logLevel into init-container and dataplane-container
  • Add BATs for extraLabels
  • Test that extraLabels get set on the deployment
  • BATs for annotations
  • Use config for log level over gcc if available
  • Make consulDataplaneContainer an assoc func to builder
  • Use logLevelForDataplaneContainer func
  • Test annotations getting set
  • Add comments for Builder obj
  • Rename config.go to gateway_config.go
  • Add comments to gateway_config
  • Move commands closer to their configuration
  • Extract some constants

How I've tested this PR

  • BATS
  • Helm generation to verify values get passed int
  • Unit testing the configuration generated for deployment resources

How I expect reviewers to test this PR

This can be reviewed mostly visually. There are certain clean ups I took the liberty of doing that are worth validating.

Checklist

@t-eckert t-eckert force-pushed the further-deployment-configuration branch from eb0e6bd to 2d9c28f Compare January 16, 2024 18:00
@t-eckert t-eckert added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jan 16, 2024
@t-eckert t-eckert marked this pull request as ready for review January 16, 2024 19:09
sarahalsmiller
sarahalsmiller approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@sarahalsmiller sarahalsmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cleanups here

jm96441n
jm96441n approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment but shouldn't hold this back, nice work!

@t-eckert t-eckert enabled auto-merge (squash) January 18, 2024 16:53
@t-eckert t-eckert merged commit 5d9bd49 into main Jan 18, 2024
27 of 48 checks passed
@t-eckert t-eckert deleted the further-deployment-configuration branch January 18, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm96441n jm96441n jm96441n approved these changes

@sarahalsmiller sarahalsmiller sarahalsmiller approved these changes

@nathancoleman nathancoleman Awaiting requested review from nathancoleman

@missylbytes missylbytes Awaiting requested review from missylbytes

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry theme/mesh-gw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-eckert @jm96441n @sarahalsmiller @missylbytes