Add -log-level flag to controller #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
ishustava and
thisisnotashwin
and removed request for
a team
ishustava
reviewed
Oct 7, 2020
subcommand/controller/command.go
Outdated
| @@ -231,6 +255,24 @@ func (c *Command) Run(args []string) int { | |||
| return 0 | |||
| } | |||
|
|
|||
| // toLevel returns the zapcore level and an error if lvl is not supported. | |||
| func toLevel(lvl string) (zapcore.Level, error) { | |||
There was a problem hiding this comment.
You could also use the UnmarshalText function from the zapcore library. Not sure if you saw it and decided not to use it for some reason. The only difference between theirs and your implementation is that theirs also accepts an all-caps string for log level, but I don't think it would be bad if we do too. WDYT?
There was a problem hiding this comment.
I also switched to using their constants. The one maybe issue is that they actually support more levels than we've documented but... probably okay?
There was a problem hiding this comment.
Awesome! Yeah, I think that's fine, given that we might switch it out to hclog.
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Apply license until success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.