Backport of [NET-6465] Respect connectInject.initContainer.resources for v1 API gateways into release/1.2.x #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/v1-api-gw-init-resources/informally-winning-dane
branch
from
1e423ab to
f053e43
Compare
|
|
…ateways (#3531) * Respect connectInject.initContainer.resources for v1 API gateways * Add changelog entry * Add test coverage for init container resources on API gateway Pods
nathancoleman
force-pushed
the
backport/v1-api-gw-init-resources/informally-winning-dane
branch
from
6076640 to
f88512a
Compare
| @@ -537,6 +537,7 @@ func (c *Command) Run(args []string) int { | |||
| ConsulTLSServerName: c.consul.TLSServerName, | |||
| ConsulPartition: c.consul.Partition, | |||
| ConsulCACert: string(caCertPem), | |||
| InitContainerResources: &initResources, | |||
There was a problem hiding this comment.
This is the only difference from the source PR that is being backported. The structure of this file changed drastically between 1.2.x and 1.3.x
missylbytes
approved these changes
Feb 7, 2024
nathancoleman
deleted the
backport/v1-api-gw-init-resources/informally-winning-dane
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is manually generated from #3531 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
Apply the existing
connectInject.initContainer.resourcesvalue to the init container for API gatewayPods.How I've tested this PR
Create an API Gateway having installed Consul into Kubernetes w/ the above field set in your
values.yaml.How I expect reviewers to test this PR
See above
Checklist
Overview of commits