Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of build.yml: Add ECR images back into release/1.3.x #3678

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3668 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@david-yu
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR

Some customers and practitioners would like AWS ECR images due the reduced cost of pulling images onto their EKS clusters. This PR makes puts back the publishing of the k8s images.

How I've tested this PR

How I expect reviewers to test this PR

Checklist


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

@david-yu david-yu closed this Feb 22, 2024
@david-yu david-yu force-pushed the backport/david-yu-ecr/unduly-one-yeti branch from 7ae8f10 to a96a70f Compare February 22, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants