Replication token needs acl write on all ns's #370
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
replication-token-global
branch
from
b25cb0c
to
bb3a68d
Compare
lkysow
requested review from
a team,
ndhanushkodi and
thisisnotashwin
and removed request for
a team
lkysow
force-pushed
the
replication-token-global
branch
from
bb3a68d
to
84f5548
Compare
lkysow
commented
Oct 29, 2020
| @@ -233,6 +232,7 @@ node_prefix "" { | |||
| {{- if .EnableNamespaces }} | |||
| namespace_prefix "" { | |||
| {{- end }} | |||
| acl = "write" | |||
There was a problem hiding this comment.
The key is here. Moving this inside the namespace_prefix "" block.
There was a problem hiding this comment.
Does namespace_prefix "" mean the token created from these rules has that permission for any namespace?
There was a problem hiding this comment.
yes exactly. If it was namespace "blah" then it would be only for blah and if it was namespace_prefix "blah-" it would be for blah-.*
| @@ -233,6 +232,7 @@ node_prefix "" { | |||
| {{- if .EnableNamespaces }} | |||
| namespace_prefix "" { | |||
| {{- end }} | |||
| acl = "write" | |||
There was a problem hiding this comment.
Does namespace_prefix "" mean the token created from these rules has that permission for any namespace?
If namespaces are enabled, the replication token will need to be able to replicate all tokens and policies from all namespaces. Without this functionality, users won't be able to use namespaced tokens/policies/roles in secondary datacenters (since they won't be replicated).
lkysow
force-pushed
the
replication-token-global
branch
from
84f5548
to
0e2cf92
Compare
ndhanushkodi
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If namespaces are enabled, the replication token will need to be able to
replicate all tokens and policies from all namespaces. Without this
functionality, users won't be able to use namespaced
tokens/policies/roles in secondary datacenters (since they won't be
replicated).
Fixes #364
How I've tested this PR:
lukeluke:curl -H "X-Consul-Token: 5207f7dd-cfb0-7d7f-b0a5-964295bcb3a1" -k https://localhost:8501/v1/acl/token/self ACL not foundnamespace_prefix ""How I expect reviewers to test this PR:
Checklist: