-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support of consul namespaces to health checks #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on my cluster with mirroring and it worked 💯 👌 .
Some suggestions around the tests and also the logic of when to add the annotation needs to be tweaked I believe.
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Note that I didn't rebuild the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a couple of comments, but they shouldn't block the merge.
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
…ations Add custom annotation for service
[Consul-ENT only]
Changes proposed in this PR:
How I've tested this PR:
unit tests have been added for the patch functionality as well as health checks resource.
How I expect reviewers to test this PR:
Unit tests.
Alternatively running and end to end test manually by:
Checklist: