Backport of remove unit test for previously removed consul-cni validation into release/1.4.x
#3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/b-consul-cni-validation-test/really-open-mastiff
branch
from
19a7199 to
d0cc38b
Compare
tgross
approved these changes
Mar 21, 2024
hc-github-team-consul-core
merged commit 80c676f
into
release/1.4.x
25 of 49 checks passed
hc-github-team-consul-core
deleted the
backport/b-consul-cni-validation-test/really-open-mastiff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3794 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
In #1527, we added support for OpenShift and Multus, which meant that the
consul-cniplugin was no longer necessarily the final CNI plugin run. While working on a patch to allow compatibility with Nomad transparent proxy, I discovered we'd never removed a now-failing unit test of the plugin for the validation step. It looks like the remaining unit tests still cover the remaining validation, so we can safely remove this test.Ref: #1527
Ref: hashicorp/nomad#10628
How I've tested this PR
How I expect reviewers to test this PR
As above
Checklist
addedremovedCHANGELOG entry addedn/aOverview of commits