Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Datadog Unix Socket Path Custom Path fix into release/1.3.x #3865

Open
wants to merge 3 commits into
base: release/1.3.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3635 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

Initial integration hard-coded Unix Domain Socket hostPath for the consul-server statefulset, making the Helm override global.metrics.datadog.dogstatsd.dogstatsdAddr not useful if users wanted/needed a custom UDS socket path beyond the default value of /var/run/datadog.

# server-statefulset.yaml
...
        volumes:
            - name: dsdsocket
              hostPath:
                  path: /var/run/datadog
                  type: DirectoryOrCreate

This PR updates this to use the helm override as intended for custom UDS paths

# server-statefulset.yaml
...
        volumes:
            - name: dsdsocket
              hostPath:
                  path: {{ dir .Values.global.metrics.datadog.dogstatsd.dogstatsdAddr | trimAll "\"" }}
                  type: DirectoryOrCreate

How I've tested this PR

Updated server-statefulset.bats with the following tests for default and non-default paths:

  • "server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using default"
  • "server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using non default"

Tested locally running a k3d cluster with latest build. Repo

How I expect reviewers to test this PR

👀 Acceptance test results

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/natemollica-nm/datadog-unix-socket-hostpath-fix/quickly-ready-puma branch from 6fbbd9a to e6d1ffa Compare April 3, 2024 18:56
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) April 3, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants