Backport of Datadog Unix Socket Path Custom Path fix into release/1.3.x #3865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3635 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
Initial integration hard-coded Unix Domain Socket
hostPath
for the consul-server statefulset, making the Helm overrideglobal.metrics.datadog.dogstatsd.dogstatsdAddr
not useful if users wanted/needed a custom UDS socket path beyond the default value of/var/run/datadog
.This PR updates this to use the helm override as intended for custom UDS paths
How I've tested this PR
Updated
server-statefulset.bats
with the following tests for default and non-default paths:"server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using default"
"server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using non default"
Tested locally running a k3d cluster with latest build. Repo
How I expect reviewers to test this PR
👀 Acceptance test results
Checklist
Overview of commits