Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog for health checks #390

Merged
merged 5 commits into from
Nov 11, 2020
Merged

update changelog for health checks #390

merged 5 commits into from
Nov 11, 2020

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Nov 11, 2020

Changes proposed in this PR:
changelog update

Checklist:

  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@kschoche kschoche requested a review from a team November 11, 2020 18:22
@kschoche kschoche self-assigned this Nov 11, 2020
@kschoche kschoche requested review from lkysow and thisisnotashwin and removed request for a team November 11, 2020 18:22
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Have provided a few suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ashwin Venkatesh <ashwin@hashicorp.com>
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Kyle! Thanks for adding all the detail to the Changelog! I left some comments and edits but other than that it's good to go! I'm approving it because I don't think my comments are blocking 😄

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
kschoche and others added 2 commits November 11, 2020 15:40
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@kschoche kschoche merged commit 25a25d4 into master Nov 11, 2020
@kschoche kschoche deleted the update_changelog_hc branch November 11, 2020 21:52
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants