Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -consul-image and -envoy-image required #405

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 26, 2020

These flags have been set in Helm for at least 9 months. If they aren't
set then our default versions were too old and wouldn't work. Making
them required means we won't need to update them here in addition to in
consul-helm.

How I've tested this PR:
I haven't but you can see the flags set here: https://github.com/hashicorp/consul-helm/blob/master/templates/connect-inject-deployment.yaml#L85-L86

How I expect reviewers to test this PR:
Code

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@lkysow lkysow marked this pull request as ready for review November 26, 2020 00:52
@lkysow lkysow requested review from a team, ishustava and thisisnotashwin and removed request for a team November 26, 2020 00:52
@@ -106,10 +106,10 @@ func (c *Command) init() {
"PEM-encoded TLS certificate to serve. If blank, will generate random cert.")
c.flagSet.StringVar(&c.flagKeyFile, "tls-key-file", "",
"PEM-encoded TLS private key to serve. If blank, will generate random cert.")
c.flagSet.StringVar(&c.flagConsulImage, "consul-image", connectinject.DefaultConsulImage,
c.flagSet.StringVar(&c.flagConsulImage, "consul-image", "",
"Docker image for Consul. Defaults to consul:1.7.1.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Docker image for Consul. Defaults to consul:1.7.1.")
"Docker image for Consul.")

These flags have been set in Helm for at least 9 months. If they aren't
set then our default versions were too old and wouldn't work. Making
them required means we won't need to update them here in addition to in
consul-helm.
@lkysow lkysow merged commit e1484f6 into master Dec 10, 2020
@lkysow lkysow deleted the require-flags branch December 10, 2020 19:54
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
When auto-encrypt is enabled we need to use the volume with
the client's CA rather than the server's.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants