Add support for ingress gateway CRD #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
igw-crd
branch
4 times, most recently
from
3ab7337 to
4d46997
Compare
lkysow
commented
Nov 27, 2020
| @@ -1,7 +1,28 @@ | |||
| # this is a generated file used for operator sdk during code generation of CRDs, Controllers and webhooks | |||
There was a problem hiding this comment.
Since this gets removed whenever we run the generation I was thinking we could leave it off.
| domain: hashicorp.com | ||
| layout: go.kubebuilder.io/v2 | ||
| repo: github.com/hashicorp/consul-k8s | ||
| resources: |
There was a problem hiding this comment.
This is added now with my version of operator-sdk
| @@ -36,6 +36,15 @@ type ServiceRouter struct { | |||
| Status `json:"status,omitempty"` | |||
| } | |||
|
|
|||
| // +kubebuilder:object:root=true | |||
There was a problem hiding this comment.
just reordering to match the other files
lkysow
requested review from
thisisnotashwin,
a team and
ndhanushkodi
and removed request for
a team
thisisnotashwin
approved these changes
Dec 14, 2020
main.go
Outdated
| "github.com/mitchellh/cli" | ||
|
|
There was a problem hiding this comment.
I suspect this change was made by Goland? I don't mind it but I think it makes sense to use the import order we use across the project
There was a problem hiding this comment.
good catch, not sure what happened there
- Also update controller-runtime to 0.4.1
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
* Run enterprise-license job on upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Use k8s image
ghcr.io/lkysow/consul-k8s-dev:nov26.Checklist: