Net 4414 remove anyuid openshift requirement #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w we can use one security context with just a switch for privileged.
missylbytes
commented
Jun 26, 2024
…erIDs to skip over
…eparated list for groups
|
Tested on open shift and saw the fix working, after Nathan and Melissa walked me through it. Reviewing the code portion now |
control-plane/go.mod
Outdated
| @@ -164,4 +164,4 @@ require ( | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
I wouldn't expect it to. The go <version> directive here specifies the minimum Go version required to run the application, not necessarily the version that it will be built with since that's determined by what version of go is installed when you're building.
There was a problem hiding this comment.
Also un-bumped go version, should be done in a separate PR
sarahalsmiller
approved these changes
Jul 9, 2024
NiniOak
reviewed
Jul 9, 2024
NiniOak
approved these changes
Jul 9, 2024
This was referenced Jul 9, 2024
nathancoleman
added a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Curt Bushko <cbushko@gmail.com> Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
nathancoleman
added a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Curt Bushko <cbushko@gmail.com> Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
sarahalsmiller
added a commit
that referenced
this pull request
Jul 10, 2024
…/1.4.x (#4160) * Net 4414 remove anyuid openshift requirement (#4152) Co-authored-by: Curt Bushko <cbushko@gmail.com> Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * fix missing field int est struct --------- Co-authored-by: Melisa Griffin <missylbytes@users.noreply.github.com> Co-authored-by: Curt Bushko <cbushko@gmail.com> Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
This PR solves two problems:
How I've tested this PR
Manual testing
Unit tests
How I expect reviewers to test this PR
Follow this gist to setup and install Consul onto Openshift
Checklist