Remove -default-protocol and annotation support #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
-default-protocol
and-enable-central-config
flags passed toconsul-k8s inject-connect
command. These flags would cause Consul to write aservice-defaults
config entry that would set the protocol of the service.consul.hashicorp.com/connect-service-protocol
annotation. Connect pods that have this annotation will not be injected and the injector will return an error.How I've tested this PR:
ghcr.io/lkysow/consul-k8s-dev:jan11
I created a service that sets the annotation and confirmed the replicaset won't start with error:How I expect reviewers to test this PR:
Checklist:
Companion to: hashicorp/consul-helm#763