Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-10871 Remove unnecessary resource permissions in connect-inject ClusterRole into release/1.4.x #4310

Conversation

hc-github-team-consul-core
Copy link

@hc-github-team-consul-core hc-github-team-consul-core commented Sep 6, 2024

Backport

This PR is auto-generated from #4307 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

Remove unnecessary permissions for Namespace and Node resources in the connect-inject controller's ClusterRole

How I've tested this PR

  • 🤖 tests pass
  • Manual smoke test running a Consul installation with service mesh and API gateways enabled

How I expect reviewers to test this PR

  • Validate against your mental model of Consul
  • (See above)

Checklist


Overview of commits

Copy link

hashicorp-cla-app bot commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

…lusterRole (#4307)

* Remove unnecessary resource permissions in connect-inject ClusterRole

* Add changelog entry

* Update unit test coverage

* Update broken unit test

* Update broken unit test

* Update broken unit test
@nathancoleman nathancoleman force-pushed the backport/connect-inject-clusterrole/plainly-patient-cattle branch from 200936e to a32fb05 Compare September 6, 2024 17:49
@nathancoleman nathancoleman marked this pull request as ready for review September 6, 2024 17:49
@nathancoleman nathancoleman merged commit b4e42e6 into release/1.4.x Sep 9, 2024
50 checks passed
@nathancoleman nathancoleman deleted the backport/connect-inject-clusterrole/plainly-patient-cattle branch September 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants