Add support for Admin Partitions to endpoints controller #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
ndhanushkodi
and removed request for
a team
ndhanushkodi
approved these changes
Sep 10, 2021
lkysow
approved these changes
Sep 14, 2021
| serviceName = strings.TrimSpace(pieces[0]) | ||
| if len(pieces) > 1 { | ||
| if r.EnableConsulNamespaces || r.EnableConsulPartitions { | ||
| pieces := strings.SplitN(parts[0], ".", 3) |
There was a problem hiding this comment.
Is this the plan for Consul DNS too? svc.ns.part?
There was a problem hiding this comment.
yup! based on conversations with @freddygv Consul DNS will become svc.ns.part
Comment on lines
+409
to
+429
| consulNamespacesEnabled: true, | ||
| consulPartitionsEnabled: true, |
There was a problem hiding this comment.
Q: Is partitions with namespaces disabled supported?
There was a problem hiding this comment.
🤔 it should be. ill write a test for it. Everything should land in the default namespace in that case.
Should we error if the namespace provided is non-default?
There was a problem hiding this comment.
No I think it's fine as is. Just might be weird for folks to have to use svc.ns.part if they don't have namespaces enabled but I think that's fine.
thisisnotashwin
force-pushed
the
endpoints-controller-partitions
branch
from
27bbecc
to
6c3a587
Compare
thisisnotashwin
added a commit
that referenced
this pull request
Sep 14, 2021
This reverts commit 8073aee.
thisisnotashwin
added a commit
that referenced
this pull request
Sep 14, 2021
thisisnotashwin
added a commit
that referenced
this pull request
Sep 16, 2021
thisisnotashwin
added a commit
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
x.y.zwhere x is the service name, y is the namespace and z is the admin partition. if there are only 2 pieces, service name and namespace are assumed. if there is only 1 piece, service name is assumed.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: