Bump Consul version to 1.10.2 #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
lkysow/consul-bump
branch
from
1e15bc7 to
90695aa
Compare
|
The world needs this PR @lkysow 😄 👍 in this PR even in draft. |
lawliet89
pushed a commit
to lawliet89/consul-k8s
that referenced
this pull request
Sep 13, 2021
If the mesh gateway tests fail, the acceptance tests will now write two files <PODNAME>-envoy-configdump.json and <PODNAME>envoy-clusters.json which will have information from the envoy admin /config_dump endpoint and /clusters endpoint. Currently we write the outputs of `kubectl logs POD` and `kubectl describe POD` for the acceptance tests, but while debugging EKS acceptance test failures, it was hard to know from our existing logs whether the mesh gateway itself is unreachable or if the consul servers behind it are unhealthy. We'd be able to tell this from looking at the envoy config dump and cluster config to see what envoy's view of the consul servers are.
lkysow
force-pushed
the
lkysow/consul-bump
branch
from
00afd55 to
69a166b
Compare
- fix tests that were failing due to a change in how the DestinationUpstream field is set in Consul OSS vs Enterprise. - set use_streaming_backend to false for Consul clients because streaming is not currently supported with mesh gateway federation
lkysow
force-pushed
the
lkysow/consul-bump
branch
from
69a166b to
4035e6e
Compare
lkysow
commented
Sep 14, 2021
| @@ -24,7 +24,8 @@ data: | |||
| in the UI. */}} | |||
| config.json: |- | |||
| { | |||
| "check_update_interval": "0s" | |||
| "check_update_interval": "0s", | |||
| "use_streaming_backend": false | |||
There was a problem hiding this comment.
I put this here because it only causes issues when doing federation and consul connect
lkysow
commented
Sep 14, 2021
| @@ -543,7 +543,7 @@ load _helpers | |||
| #-------------------------------------------------------------------- | |||
| # config-configmap | |||
|
|
|||
| @test "client/DaemonSet: adds config-checksum annotation when extraConfig is blank" { | |||
There was a problem hiding this comment.
just re-worded the test titles a bit here because it always adds the config-checksum annotation so really what we're testing is that the checksum changes when the configmap is different
lkysow
requested review from
a team,
ishustava and
t-eckert
and removed request for
a team
t-eckert
approved these changes
Sep 14, 2021
ishustava
approved these changes
Sep 14, 2021
t-eckert
pushed a commit
that referenced
this pull request
Sep 17, 2021
- fix tests that were failing due to a change in how the DestinationUpstream field is set in Consul OSS vs Enterprise. - set use_streaming_backend to false for Consul clients because streaming is not currently supported with mesh gateway federation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DestinationUpstream field is set in Consul OSS vs Enterprise.
streaming is not currently supported with mesh gateway federation
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: