Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better error when using default service acct #842

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Give better error when using default service acct #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a425c5
Give better error when using default service acct
lkysow Nov 4, 2021
b71595f
Add changelog
lkysow Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
IMPROVEMENTS:
* Control Plane
* TLS: Support PKCS1 and PKCS8 private keys for Consul certificate authority. [[GH-843](https://github.com/hashicorp/consul-k8s/pull/843)]
* Connect: Log a warning when ACLs are enabled and the default service account is used. [[GH-842](https://github.com/hashicorp/consul-k8s/pull/842)]
* CLI
* Delete jobs, cluster roles, and cluster role bindings on `uninstall`. [[GH-820](https://github.com/hashicorp/consul-k8s/pull/820)]

Expand Down
6 changes: 6 additions & 0 deletions control-plane/subcommand/connect-init/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ func (c *Command) Run(args []string) int {
return err
}, backoff.WithMaxRetries(backoff.NewConstantBackOff(1*time.Second), numLoginRetries))
if err != nil {
if c.flagServiceAccountName == "default" {
c.logger.Warn("The service account name for this Pod is \"default\"." +
" In default installations this is not a supported service account name." +
" The service account name must match the name of the Kubernetes Service" +
" or the consul.hashicorp.com/connect-service annotation.")
}
c.logger.Error("Hit maximum retries for consul login", "error", err)
return 1
}
Expand Down