-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI Upgrade command #898
Conversation
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
* Add base bootstrapping logic and acceptance tests for gossip encryption in Vault Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
* Change vault cluster in acceptance tests to only run with TLS. All tests will run against vault with TLS because that is the use case we think will be the most valuable for users to test * Support adding Vault CA as a secret to pods that will be using vault agent. We need to add two annotations to pods: * vault.hashicorp.com/agent-extra-secret with the value of the vault CA secret name. The secret will be mounted to vault agent at /vault/custom path. See docs here * vault.hashicorp.com/ca-cert - with the path of the ca file inside the vault agent container. This should be /vault/custom/<secret key> * Most pods will only need those annotations. The server pods also need the Vault CA secret to be mounted as a volume because it needs the CA to be on the file system for the vault connect CA provider.
…ssues with the connect-injector webhook not starting on an install?
…ssues with the connect-injector webhook not starting on an install?
This reverts commit 65a91a9.
add psp support when its configured in acceptance tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Thanks for wrapping this up Thomas! Mostly had some small comments, and +1 to David's comment to re-enable the presets. I have a little bit of manual testing left to try but wanted to leave this review now so you can start! Finished doing some testing, haven't run into anything weird yet!
I think the acceptance tests are failing because we need to rebase this on main |
…ssues with the connect-injector webhook not starting on an install?
…ssues with the connect-injector webhook not starting on an install?
Closing because of weird git stuff... |
This is a wrap-up of Saad's excellent work on the Upgrade command. There will need to be some refactors following this, but functionality is solid.
Changes proposed in this PR:
How I've tested this PR:
Checkout an older version of the CLI and compile it.
cd cli git checkout tags/v0.37.0 go build -o consul-k8s-0-37-0
Checkout this version and compile it
Install Consul with the older version, optionally include a preset.
Apply a static server/client pair to the cluster.
K8s Config
Exec into the client pod
In the client pod, cURL the server pod:
You should receive "hello, world" back. Exit the pod.
Now perform the upgrade with the latest version of the CLI, optionally modifying the preset.
Exec into the client pod again, cURL the server pod, and ensure that you still receive "hello, world".
How I expect reviewers to test this PR:
You can do what I did above. I believe in you.
Checklist: