Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tproxy for partitions test #901

Merged
merged 16 commits into from
Dec 8, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Dec 6, 2021

Changes proposed in this PR:

  • Update the partition acceptance tests with support for t-proxy tests for x-partition networking and in partition networking as well.

How I've tested this PR:

  • acceptance tests.
    How I expect reviewers to test this PR:
  • code review

Checklist:

  • Tests added

@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch from 142dd4d to 644dbda Compare December 6, 2021 18:13
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch 3 times, most recently from 73205a7 to 436a570 Compare December 6, 2021 19:01
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch 2 times, most recently from d743c67 to 0dfdb93 Compare December 6, 2021 19:45
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from 436a570 to 575ecc1 Compare December 6, 2021 19:48
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch 4 times, most recently from 08419c2 to c7d83c5 Compare December 6, 2021 23:32
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from 575ecc1 to 0507cd6 Compare December 7, 2021 15:00
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch from c7d83c5 to dbc925a Compare December 7, 2021 15:07
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from 3f7c5eb to c90e830 Compare December 7, 2021 15:11
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch 4 times, most recently from 471f751 to eb2f4c8 Compare December 7, 2021 20:42
@thisisnotashwin thisisnotashwin requested review from a team, ndhanushkodi and kschoche and removed request for a team December 7, 2021 20:48
@thisisnotashwin thisisnotashwin marked this pull request as ready for review December 7, 2021 20:48
@thisisnotashwin thisisnotashwin requested review from lkysow and removed request for ndhanushkodi December 7, 2021 20:48
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧯

@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from 1c0de55 to c7782a8 Compare December 7, 2021 20:56
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch from eb2f4c8 to a080ddc Compare December 7, 2021 21:28
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from c7782a8 to b45f341 Compare December 7, 2021 21:52
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch 3 times, most recently from 2692dc9 to 4710a83 Compare December 8, 2021 01:00
@thisisnotashwin thisisnotashwin force-pushed the rename-to-exported-services branch from b45f341 to ed81558 Compare December 8, 2021 15:58
Base automatically changed from rename-to-exported-services to main December 8, 2021 17:36
@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch from 296da62 to dd60b95 Compare December 8, 2021 17:46
@thisisnotashwin thisisnotashwin merged commit ce6b2a7 into main Dec 8, 2021
@thisisnotashwin thisisnotashwin deleted the update-acceptance-for-tproxy branch December 8, 2021 17:47
rrondeau pushed a commit to rrondeau/consul-k8s that referenced this pull request Dec 21, 2021
…hashicorp#901)

* Use disableHostNodeID param in values.yaml to configure Consul client
* Remove comment about multi-agent testing since this will be a DaemonSet
* Add bats tests for disableHostNodeID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants