Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr/938: [charts/consul] - Enable terminationGracePeriodSeconds customization on ingressGateway #947

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Pr/938: [charts/consul] - Enable terminationGracePeriodSeconds customization on ingressGateway #947

merged 3 commits into from
Jan 4, 2022

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Jan 4, 2022 •
edited
Loading

Changes proposed in this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Lord-Y added 2 commits January 4, 2022 09:51
@Lord-Y @ndhanushkodi
[charts/consul] - Enable terminationGracePeriodSeconds customization
533964d 
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
@Lord-Y @ndhanushkodi
[charts/consul] - Update terminationGracePeriodSeconds test
190e87c 
Signed-off-by: Lord-Y <Lord-Y@users.noreply.github.com>
@ndhanushkodi ndhanushkodi mentioned this pull request Jan 4, 2022
Closed
1 task
@ndhanushkodi ndhanushkodi merged commit b632426 into main Jan 4, 2022
@ndhanushkodi ndhanushkodi deleted the pr/938 branch January 4, 2022 19:18
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
@lkysow
Changlog for hashicorp#932 (hashicorp#947)
d7913b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@t-eckert t-eckert Awaiting requested review from t-eckert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndhanushkodi @ishustava @Lord-Y