Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for #923 #957

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Update CHANGELOG.md for #923 #957

merged 2 commits into from
Jan 13, 2022

Conversation

ishustava
Copy link
Contributor

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava requested review from a team, ndhanushkodi and t-eckert and removed request for a team January 10, 2022 22:12
t-eckert
t-eckert approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
@ishustava
Apply suggestions from code review
73e09f8 
Co-authored-by: Thomas Eckert <teckert@hashicorp.com>
@ishustava ishustava merged commit 3b37196 into main Jan 13, 2022
@ishustava ishustava deleted the ishustava-patch-1 branch January 13, 2022 01:41
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
@ishustava
Separate tproxy tests (hashicorp#957)
aba0aa1 
* Add -enable-transparent-proxy flag to the acceptance tests flags which allows you to globally enable or disable tproxy for all tests
* Update all (except a few) connect-related tests to now reach upstreams via kube DNS when transparent proxy is enabled
* Refactor circleci to add commands that we can re-use when running acceptance tests
* Add acceptance tests job with tproxy enabled in parallel to the regular job to be run on every PR
* Enable tproxy on all nightly acceptance tests
* Disable some tests when tproxy is enabled due to either bugs or flakiness (to be fixed later) mesh gateway test with explicit upstreams doesn't work right now because of a bug in consul that is not yet fixed RestartConsulClients connect test is flakey.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishustava @ndhanushkodi @thisisnotashwin @t-eckert