Create anonymous-policy and token from non-default partitions. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
ndhanushkodi,
a team and
ishustava
and removed request for
a team
ndhanushkodi
approved these changes
Jan 18, 2022
|
Oh I see it got updated to draft, just re-request me if you need a review again later |
Exactly!!
Yeah. Iryna and I had a conversation and I think I know how I want to test this. Will un-draft it once I have a unit test and re-request a review. Sorry bout that. |
thisisnotashwin
force-pushed
the
always-create-anon-token
branch
from
60c54bf to
86d1565
Compare
thisisnotashwin
force-pushed
the
always-create-anon-token
branch
from
86d1565 to
03c7e3b
Compare
thisisnotashwin
commented
Jan 21, 2022
| @@ -129,4 +129,6 @@ require ( | |||
| sigs.k8s.io/yaml v1.2.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/hashicorp/consul/sdk v0.9.0 => github.com/hashicorp/consul/sdk v0.4.1-0.20220120214936-7568f3a102a8 | |||
There was a problem hiding this comment.
This was to update the version of the consul/sdk without impacting the version of the consul/api.
thisisnotashwin
commented
Jan 21, 2022
.circleci/config.yml
Outdated
| @@ -70,7 +70,7 @@ commands: | |||
| type: string | |||
| consul-k8s-image: | |||
| type: string | |||
| default: "docker.mirror.hashicorp.services/hashicorpdev/consul-k8s-control-plane:latest" | |||
| default: "ashwinvenkatesh/consul-k8s@sha256:9b46fae446fcf99c715d9063231857eef5525830f2cd3cdcb46266c84db11deb" | |||
There was a problem hiding this comment.
Will be deleted before merge.
ishustava
approved these changes
Jan 21, 2022
ndhanushkodi
approved these changes
Jan 24, 2022
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: