Support the value $POD_NAME for the annotation
#982
Conversation
thisisnotashwin
force-pushed
the
ashwin/service-meta-pod_name
branch
from
3c7db3c to
400b8fc
Compare
thisisnotashwin
added
area/connect
thisisnotashwin
changed the title
$POD_NAME for the annotation `consul.hashicorp.co…$POD_NAME for the annotation
thisisnotashwin
requested review from
a team,
kschoche and
ishustava
and removed request for
a team
…m/service-meta-pod_name`
thisisnotashwin
force-pushed
the
ashwin/service-meta-pod_name
branch
from
400b8fc to
6ff8ff6
Compare
| @@ -9,6 +9,8 @@ IMPROVEMENTS: | |||
| * Allow customization of `terminationGracePeriodSeconds` on the ingress gateways. [[GH-947](https://github.com/hashicorp/consul-k8s/pull/947)] | |||
| * Support `ui.dashboardURLTemplates.service` value for setting [dashboard URL templates](https://www.consul.io/docs/agent/options#ui_config_dashboard_url_templates_service). [[GH-937](https://github.com/hashicorp/consul-k8s/pull/937)] | |||
| * Allow using dash-separated names for config entries when using `kubectl`. [[GH-965](https://github.com/hashicorp/consul-k8s/pull/965)] | |||
| * Control Plane | |||
| * Support the value `$POD_NAME` for the annotation `consul.hashicorp.com/service-meta-pod_name` that will now be interpolated and set to the pod name in the service's metadata. [[GH-982](https://github.com/hashicorp/consul-k8s/pull/982)] | |||
There was a problem hiding this comment.
@thisisnotashwin it's supported for any meta annotation right? Not just service-meta-pod_name but also service-meta-foo for example.
There was a problem hiding this comment.
not really. I asked @david-yu and the ask from the customer is to only support $POD_NAME.
There was a problem hiding this comment.
@thisisnotashwin Similar question that @lkysow asked. Should it support any meta annotation? I'm looking to also grab the pod-namespace. I can make a similar PR but then we get into different territory of adding every single metadata that we might need and doesn't seem sustainable
There was a problem hiding this comment.
or would it make sense to add another value for $POD_NAMESPACE?
There was a problem hiding this comment.
Hey @jeenx !! Currently we have only added support for the value $POD_NAME. I agree that adding a separate PR per env var is not sustainable, but in this case, these env vars are not actually set in the runtime env. We are actually replacing it with the value pod.Name(). Hence we would need to this do on a per env basis as it is hard to determine whether the desired variable does exist in the env or not.
There was a problem hiding this comment.
It's also important to note that this isn't actually an env var. We're doing this in the endpoints controller that doesn't have access to the actual pod's environment variables. So we can only support data we actually have when looking at the pod yaml.
There was a problem hiding this comment.
Got it, would it be possible to add all that data that is available on the pod (e.g, namespace)?
Changes proposed in this PR:
consul.hashicorp.com/service-meta-pod_name: $POD_NAMEwhere $POD_NAME will be replaced with the Pod's name. This mimics the support we had before the endpoints controller where environment variables were interpolated for tags.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: