Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: update PR link #998

Merged
merged 1 commit into from
Jan 26, 2022
Merged

CHANGELOG: update PR link #998

merged 1 commit into from
Jan 26, 2022

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Jan 26, 2022 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

CHANGELOG: update PR link
b16b663 
Update PR link to #993
thisisnotashwin
thisisnotashwin approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!! thanks David.

@david-yu david-yu merged commit bfd2b44 into main Jan 26, 2022
@david-yu david-yu deleted the david-yu-changelog-pr branch January 26, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-yu @thisisnotashwin