-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: add support for arm64 platfrom #1251
Conversation
Signed-off-by: Liu Hua <sdu.liu@huawei.com>
Hey @liusdu, thanks for taking the time to submit the PR. I'd be happy to merge this but can't without the CLA. Can you sign it? |
Hi @eikenb I cannot find what is wrong with it. Actually I signed the cla. |
@liusdu, that is very strange. I'm not sure what would have kept it from registering that you signed the CLA. It is a github thing that they don't provide much insight into. I guess opening a new PR is the quickest/simplest path forward. Sorry for the inconvenience and thanks. |
@evanphx Done! thank you very much! |
FYI. I'm going to be changing all the ARM builds to enable CGO due to upstream Go bug: golang/go#32912. It hasn't been enabled before now, but wasn't a problem as I don't think anyone used them (else I suspect someone would have filed an issue). But I assume that you submitted this as you would want to use them. So working binaries are probably needed. |
Didn't notice until after I merged it but the arm64 exclude entries (eg. freebsd/arm64) match both the arm and arm64 entries, preventing both. After some playing around I decided to just keep the more restrictive arm builds (only build arm for Linux) that you have and just removed the '*/arm' entries. I think this is pretty safe as I don't think anyone is using the any of the arm builds as they should all be broken due to that golang bug. If this ends up being an issue it is easy enough to rework the builds. |
it works well on my env
Signed-off-by: Liu Hua sdu.liu@huawei.com