fix issue returning typed nil pointers #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 3 template functions; secrets, caLeafe and node
These functions returned typed pointers as their data field. Template
execution didn't like these typed nil pointer values when looking up
data on them. Changing them to return untyped pointers with an function
signature returning interface{} fixes this as the template knows to have
these always return '<no value>'.
eikenb
added
bug
hashicat-update-required
|
Thanks @lornasong!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 3 template functions; secrets, caLeafe and node
These functions returned typed pointers as their data field. Template
execution didn't like these typed nil pointer values when looking up
data on them. Changing them to return untyped pointers with an function
signature returning interface{} fixes this as the template knows to have
these always return
<no value>.Fixes #1418