Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user set in dockerfile #1662

Merged
merged 1 commit into from
Nov 2, 2022
Merged

fix: user set in dockerfile #1662

merged 1 commit into from
Nov 2, 2022

Conversation

matthugs
Copy link
Contributor

@matthugs matthugs commented Nov 2, 2022

my organization is currently auditing whether any docker images we run are currently using the root user. From dockerhub it looks like this line expands out to USER : since the env var names don't match. (see https://hub.docker.com/layers/hashicorp/consul-template/0.29/images/sha256-32f8ffb8db51809d93488527d63f97d267e2a10c0cbe96dfa5cbc408266211ab?context=explore) This would fix this so that your images are run as the user you create earlier in the dockerfile.

my organization is currently auditing whether any docker images we run
are currently using the root user. From dockerhub it looks like this
line expands out to `USER :` since the env var names don't match. (see
https://hub.docker.com/layers/hashicorp/consul-template/0.29/images/sha256-32f8ffb8db51809d93488527d63f97d267e2a10c0cbe96dfa5cbc408266211ab?context=explore)
This would fix this so that your images are run as the user you create
earlier in the dockerfile.
@matthugs matthugs requested a review from a team November 2, 2022 14:40
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 2, 2022

CLA assistant check
All committers have signed the CLA.

@eikenb eikenb added this to the v0.30.0 milestone Nov 2, 2022
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that got missed when migrating to our new release process. Thanks!

@eikenb eikenb merged commit 7647b78 into hashicorp:main Nov 2, 2022
@matthugs matthugs deleted the matthugs/set-user-in-dockerfile-to-newly-created-user branch November 2, 2022 19:00
@eikenb eikenb modified the milestones: v0.30.0, 0.29.6 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants