Re-open: Implement systemd notification support after all templates have been rendered #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @skpratt |
|
@skpratt This is a friendly reminder, I would really like you to consider this change |
skpratt
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the functionality to notify systemd once consul-template has completed its initial run. It's worth noting that a similar feature request was made in the past (Issue #1011), but was not accepted. However, after further consideration and understanding the evolving needs of the community, I believe it's time to revisit this feature.
Here are my reasons why it is important to add:
As modern infrastructure continues to evolve, the integration between tools becomes increasingly crucial. The ability for consul-template to notify systemd can streamline service initialization, ensuring that dependent services only start once their configurations are ready.
This feature will provide a more seamless experience for users who rely on systemd for process management. It will eliminate the need for workarounds, such as running consul-template -once.
Other tools in the ecosystem have integrated with init systems like systemd. This shows a recognized need in the community for such integrations. By adding this functionality to consul-template, we ensure that it remains competitive and relevant in the ever-changing landscape of DevOps tools.
In conclusion, while I understand and respect the decisions made in the past, I believe that the current landscape and the needs of the community warrant a reconsideration of this feature. I hope we can have a constructive discussion around this and work towards the betterment of consul-template.