cli: Output message on success writing config entry

hashicorp · May 7, 2020 · 330aa89 · 330aa89
1 parent f0df674
commit 330aa89
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/command/config/write/config_write.go b/command/config/write/config_write.go
@@ -95,7 +95,7 @@ func (c *cmd) Run(args []string) int {
 		return 1
 	}
 
-	// TODO (mkeeler) should we output anything when successful
+	c.UI.Info(fmt.Sprintf("Config entry %q / %q updated successfully", entry.GetKind(), entry.GetName()))
 	return 0
 }
 

diff --git a/command/config/write/config_write_test.go b/command/config/write/config_write_test.go
@@ -48,6 +48,8 @@ func TestConfigWrite(t *testing.T) {
 
 		code := c.Run(args)
 		require.Empty(t, ui.ErrorWriter.String())
+		require.Contains(t, ui.OutputWriter.String(),
+			`Config entry "service-defaults" / "web" updated successfully`)
 		require.Equal(t, 0, code)
 
 		entry, _, err := client.ConfigEntries().Get("service-defaults", "web", nil)
@@ -85,6 +87,8 @@ func TestConfigWrite(t *testing.T) {
 
 		code := c.Run(args)
 		require.Empty(t, ui.ErrorWriter.String())
+		require.Contains(t, ui.OutputWriter.String(),
+			`Config entry "proxy-defaults" / "global" updated successfully`)
 		require.Equal(t, 0, code)
 
 		entry, _, err := client.ConfigEntries().Get(api.ProxyDefaults, api.ProxyConfigGlobal, nil)