Guard against setting on destroyed object

hashicorp · Oct 16, 2023 · 4882490 · 4882490
1 parent 838a8a9
commit 4882490
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/ui/packages/consul-ui/app/components/code-editor/index.js b/ui/packages/consul-ui/app/components/code-editor/index.js
@@ -36,22 +36,24 @@ export default Component.extend({
     }
   },
   setMode: function (mode) {
-    let options = {
-      ...DEFAULTS,
-      mode: mode.mime,
-      readOnly: this.readonly,
-    };
-    if (mode.name === 'XML') {
-      options.htmlMode = mode.htmlMode;
-      options.matchClosing = mode.matchClosing;
-      options.alignCDATA = mode.alignCDATA;
-    }
-    set(this, 'options', options);
+    if (!this.isDestroying && !this.isDestroyed) {
+      let options = {
+        ...DEFAULTS,
+        mode: mode.mime,
+        readOnly: this.readonly,
+      };
+      if (mode.name === 'XML') {
+        options.htmlMode = mode.htmlMode;
+        options.matchClosing = mode.matchClosing;
+        options.alignCDATA = mode.alignCDATA;
+      }
+      set(this, 'options', options);
 
-    const editor = this.editor;
-    editor.setOption('mode', mode.mime);
-    this.helper.lint(editor, mode.mode);
-    set(this, 'mode', mode);
+      const editor = this.editor;
+      editor.setOption('mode', mode.mime);
+      this.helper.lint(editor, mode.mode);
+      set(this, 'mode', mode);
+    }
   },
   willDestroyElement: function () {
     this._super(...arguments);