backport of commit b5fa4f2

hashicorp · Oct 24, 2023 · 755dcba · 755dcba
1 parent bcf44a1
commit 755dcba
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/internal/mesh/internal/controllers/xds/controller_test.go b/internal/mesh/internal/controllers/xds/controller_test.go
@@ -1039,9 +1039,8 @@ func (suite *xdsControllerTestSuite) TestReconcile_SidecarProxyGoldenFileInputs(
 				golden.GetBytesAtFilePath(suite.T(), fmt.Sprintf("%s/%s.golden", path, name)))
 
 			// Destinations will need endpoint refs set up.
-			proxyType := strings.Split(name, "/")[0]
-			if proxyType == "destination" && len(pst.ProxyState.Endpoints) == 0 {
-				suite.addRequiredEndpointsAndRefs(pst, proxyType)
+			if strings.Split(name, "/")[0] == "destination" && len(pst.ProxyState.Endpoints) == 0 {
+				suite.addRequiredEndpointsAndRefs(pst)
 			}
 
 			// Store the initial ProxyStateTemplate.
@@ -1085,7 +1084,7 @@ func (suite *xdsControllerTestSuite) TestReconcile_SidecarProxyGoldenFileInputs(
 	}
 }
 
-func (suite *xdsControllerTestSuite) addRequiredEndpointsAndRefs(pst *pbmesh.ProxyStateTemplate, proxyType string) {
+func (suite *xdsControllerTestSuite) addRequiredEndpointsAndRefs(pst *pbmesh.ProxyStateTemplate) {
 	//get service data
 	serviceData := &pbcatalog.Service{}
 	var vp uint32 = 7000