Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: mrspanishviking <kcardenas@hashicorp.com>
  • Loading branch information
banks and mrspanishviking authored Sep 28, 2021
1 parent 6216c1b commit 95688a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ spec:
name: 'SDS',
yaml: false,
type: 'SDSConfig: <optional>',
description: "Configures the gateway to load TLS certificates from an external SDS service. See [SDS](/docs/connect/gateways/ ingress-gateway#sds) for more details on usage.<br><br>SDS properties set here will be used as defaults for all listeners on the gateway.",
description: "Configures the gateway to load TLS certificates from an external SDS service. See [SDS](/docs/connect/gateways/ingress-gateway#sds) for more details on usage.<br><br>SDS properties set here will be used as defaults for all listeners on the gateway.",
children: [
{
name: 'ClusterName',
Expand Down
7 changes: 3 additions & 4 deletions website/content/docs/connect/gateways/ingress-gateway.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ must also provide `agent:read` for its node's name in order to discover the agen

~> [Configuration entries](/docs/agent/config-entries) are global in scope. A configuration entry for a gateway name applies
across all federated Consul datacenters. If ingress gateways in different Consul datacenters need to route to different
sets of services within their datacenter then the ingress gateways **must** be registered with different names.
sets of services within their datacenter, then the ingress gateways **must** be registered with different names.

<!-- Add a "permalink" anchor here since this title is long and may be edited
but we need to deep-link to it elsewhere -->
<a name="sds"></a>

## Custom TLS Certificates via Secret Discovery Service (SDS)

~> **Advanced Topic!** This is a low-level feature designed for developers
~> **Advanced Topic** This is a low-level feature designed for developers
building integrations with custom TLS management solutions.

Consul 1.11 added support for Ingress Gateways to serve TLS certificates to
Expand Down Expand Up @@ -176,8 +176,7 @@ EOF
```

**Run `consul services register public-ingress.hcl`** to create the
registration. This must be run on the node where the Envoy proxy is going to run
to register the proxy with the local Consul agent.
registration. The command must be executed on the node where the Envoy proxy will register the proxy with the local Consul agent.

#### 1.2 Setup TLS Client Authentication for SDS

Expand Down

0 comments on commit 95688a5

Please sign in to comment.