Skip to content

Commit

Permalink
ui: Fix for differences between uncompiled and compiled CSS (#7233)
Browse files Browse the repository at this point in the history
We noticed that this relative positioning is not even applied when the CSS is
compiled/compressed. When looking via Web Inspector this style/selector
doesn't even appear even though it is in the CSS source.

This !important reduces the amount of selectors for this style rule,
which fixes the error, so potentially this isn't a specificity thing.
  • Loading branch information
johncowen authored Feb 6, 2020
1 parent ad3b532 commit 9e186c7
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion ui-v2/app/styles/base/components/menu-panel/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,13 @@
padding: 10px;
padding-left: 36px;
}
/* here the !important is only needed for what seems to be a difference */
/* with the CSS before and after compression */
/* i.e. before compression this style is applied */
/* after compression it is in the source but doesn't seem to get */
/* applied (unless you add the !important) */
%menu-panel .is-active {
position: relative;
position: relative !important;
}
%menu-panel .is-active > *::after {
position: absolute;
Expand Down

0 comments on commit 9e186c7

Please sign in to comment.