ui: Fix empty SVG height to prevent service mesh from breaking when t…

…here are no upstreams (#10122)
hashicorp · May 5, 2021 · c41ef2d · c41ef2d
1 parent 1d6ebf0
commit c41ef2d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/.changelog/10122.txt b/.changelog/10122.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Adding conditional to prevent Service Mesh from breaking when there are no Upstreams
+```
diff --git a/ui/packages/consul-ui/app/components/topology-metrics/index.js b/ui/packages/consul-ui/app/components/topology-metrics/index.js
@@ -108,14 +108,16 @@ export default class TopologyMetrics extends Component {
     // Calculate viewBox dimensions
     this.downView = document.getElementById('downstream-lines').getBoundingClientRect();
     const upstreamLines = document.getElementById('upstream-lines').getBoundingClientRect();
-    const upstreamColumn = document.getElementById('upstream-column').getBoundingClientRect();
-
-    this.upView = {
-      x: upstreamLines.x,
-      y: upstreamLines.y,
-      width: upstreamLines.width,
-      height: upstreamColumn.height,
-    };
+    const upstreamColumn = document.getElementById('upstream-column');
+
+    if (upstreamColumn) {
+      this.upView = {
+        x: upstreamLines.x,
+        y: upstreamLines.y,
+        width: upstreamLines.width,
+        height: upstreamColumn.getBoundingClientRect().height + 10,
+      };
+    }
 
     // Get Card elements positions
     const downCards = [