Small premature optimization in isUUID().

If the length isn't `36`, return `false` immediately before firing up the regexp engine.
hashicorp · Feb 1, 2017 · c5e140c · c5e140c
1 parent 0a34925
commit c5e140c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/consul/state/prepared_query.go b/consul/state/prepared_query.go
@@ -14,6 +14,11 @@ var validUUID = regexp.MustCompile(`(?i)^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f
 
 // isUUID returns true if the given string is a valid UUID.
 func isUUID(str string) bool {
+	const uuidLen = 36
+	if len(str) != uuidLen {
+		return false
+	}
+
 	return validUUID.MatchString(str)
 }