Skip to content

Commit

Permalink
tmp: add TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
zalimeni authored and jmurret committed Oct 25, 2023
1 parent 3b3dd5b commit d711f0b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/mesh/internal/types/proxy_state_template.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package types

import (
"fmt"

"github.com/hashicorp/go-multierror"

"github.com/hashicorp/consul/acl"
Expand Down Expand Up @@ -92,6 +91,11 @@ func ValidateProxyStateTemplate(res *pbresource.Resource) error {
}))
}

//TODO: Call exports.go proxy of validators.go's protocol validation code, ensure it's set to not-unspecified enum value
// (That export also needs to be added, see examples there)
//TODO: Add golden test coverage of the changes made to Cluster to include protocol
//TODO: Clean up commit message

wrapGroupErr := func(err error) error {
return wrapClusterErr(resource.ErrInvalidField{
Name: "group",
Expand Down

0 comments on commit d711f0b

Please sign in to comment.