Skip to content

Commit

Permalink
Add TODOs for failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tiwilliam committed May 9, 2014
1 parent 335cd5a commit dcfd03b
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions command/agent/catalog_endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ func TestCatalogNodes_Blocking(t *testing.T) {

// Should block for a while
if time.Now().Sub(start) < 50 * time.Millisecond {
// TODO: Failing
t.Fatalf("too fast")
}

Expand Down
7 changes: 7 additions & 0 deletions command/agent/health_endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ func TestHealthChecksInState(t *testing.T) {
if err != nil {
t.Fatalf("err: %v", err)
}

// TODO: Failing
assertIndex(t, resp)

// Should be 1 health check for the server
Expand Down Expand Up @@ -105,6 +107,7 @@ func TestHealthServiceChecks(t *testing.T) {
// Should be 1 health check for consul
nodes := obj.(structs.HealthChecks)
if len(nodes) != 1 {
// TODO: Failing
t.Fatalf("bad: %v", obj)
}
}
Expand All @@ -127,6 +130,8 @@ func TestHealthServiceNodes(t *testing.T) {
if err != nil {
t.Fatalf("err: %v", err)
}

// TODO: Failing
assertIndex(t, resp)

// Should be 1 health check for consul
Expand Down Expand Up @@ -172,6 +177,8 @@ func TestHealthServiceNodes_PassingFilter(t *testing.T) {
if err != nil {
t.Fatalf("err: %v", err)
}

// TODO: Failing
assertIndex(t, resp)

// Should be 0 health check for consul
Expand Down
1 change: 1 addition & 0 deletions command/agent/rpc_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ OUTER1:
}
}
if !found {
// TODO: Failing
t.Fatalf("should log client accept")
}

Expand Down
2 changes: 2 additions & 0 deletions command/agent/ui_endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ func TestUiNodeInfo(t *testing.T) {
if err != nil {
t.Fatalf("err: %v", err)
}

// TODO: Failing
assertIndex(t, resp)

// Should be 1 node for the server
Expand Down
1 change: 1 addition & 0 deletions consul/catalog_endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ func TestCatalogListServices_Timeout(t *testing.T) {

// Should block at least 100ms
if time.Now().Sub(start) < 100 * time.Millisecond {
// TODO: Failing
t.Fatalf("too fast")
}

Expand Down

0 comments on commit dcfd03b

Please sign in to comment.